[earlgrey,dv] Remove bogus dbg device from TopEarlgrey#29617
Draft
rswarbrick wants to merge 2 commits intolowRISC:masterfrom
Draft
[earlgrey,dv] Remove bogus dbg device from TopEarlgrey#29617rswarbrick wants to merge 2 commits intolowRISC:masterfrom
rswarbrick wants to merge 2 commits intolowRISC:masterfrom
Conversation
This was added for Darjeeling and it appears the engineers concerned didn't think about the fact this would convince various bits of tooling that the phantom interface exists for Earlgrey too. The bulk of this commit is tidying up the logic in topgen's lib.py, merge.py and top_uvm_reg.sv.tpl to allow the possibility that an instance of a block doesn't connect up all the interfaces that the block defines. To do this properly, it also fixes some incorrect type annotations in the code (which seem to have been introduced when first adding multiple address maps). The Earlgrey-specific change is tiny: it's just remove the "dmi" line in hw/top_earlgrey/data/top_earlgrey.hjson, together with the comment that shows the author realises it didn't make much sense... Signed-off-by: Rupert Swarbrick <rswarbrick@lowrisc.org>
This is analogous to the commit that removes a nonexistent dmi device from lc_ctrl, but it's a much simpler commit, because all the engineering work is in that one. The only manual change in this commit is deleting a line from top_earlgrey.hjson. Signed-off-by: Rupert Swarbrick <rswarbrick@lowrisc.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is in draft, because it builds on #29616 (the first commit in this PR)
This is analogous to the commit that removes a nonexistent dmi device from lc_ctrl, but it's a much simpler commit, because all the engineering work is in that one. The only manual change in this commit is deleting a line from top_earlgrey.hjson.